[Fixed - 3.86] New submenus in menudef_ fail to display diy_ recipes

[Galgana]

The legacy method (NOT prefixed with mod_) for adding recipes to new submenus is broken. This is contrary to the changelog for version 3.86:

The existing method of adding modded items to the original [M]ake menu with diy_*.txt and menudef_*.txt files still works the same as always, so there are no changes required for your mods unless you want to separate them from the original [M]ake menu.

These are the contents of files I added for testing:

menudef_new.txt

Code: [Select]

.new. -E- *MAKE*
diy_new.txt

Code: [Select]

[SUBMENU_START:new]

.Rock. /1/
{[NEARBY_TILE:Ground]} 'on the ground'

[SUBMENU_END:new]
When I select a new submenu, nothing happens. It is recorded in the message log that I have selected that handcraft submenu, but the submenu itself does not appear.
Other things worth noting:

• DIY additions to the base game's pre-existing submenus display as normal.
• Adding mod_ prefix to the above files does work as intended.
• Users of the BAC modpack (updated for version 3.86) have reported that new cookery submenus do not show up, although I have not observed this happening in my own non-BAC modlist where custom cookery submenus from menudef_*.txt +  cookery_*.txt recipes display as normal.

[Sami]

Oh my, indeed it seems to broken - and it's a bit disturbing.
With quick a debugging it seems the check for mod_diy_ entries within the make menu somehow clears up the hotkeys/selections to enter the diy_ submenus.
Should be quite easily fixable, but I wish we had noticed this earlier.

As for the cookery submenu issue it would be easiest to check out if there were a bug report with simple modding snippets (like in your post) that fail to work as intended.
But I'll try to look up the possible bug potential there as well after this primary case is fixed.

[Sami]

Alright, I got this one fixed now.

Users of the BAC modpack (updated for version 3.86) have reported that new cookery submenus do not show up, although I have not observed this happening in my own non-BAC modlist where custom cookery submenus from menudef_*.txt +  cookery_*.txt recipes display as normal.

With a quick look I came to a conclusion that BAC probably misses the custom cookery submenu definitions that should be placed in menudef_*.txt files.

Fixed - persist in 3.86.1

[Felis_Citrus]

Greetings! Is this still broken? It seems to still be an issue, since my BAC submenus dont display anything, and my custom submenus dont either. Im on windows playing on version 3.86.1.

I tried the fix using mod_ and it was functional, but without it it showed nothing.

[Sami]

Greetings! Is this still broken? It seems to still be an issue, since my BAC submenus dont display anything, and my custom submenus dont either. Im on windows playing on version 3.86.1.

I tried the fix using mod_ and it was functional, but without it it showed nothing.

Yes it's still broken, the bug persists in current version 3.86.1.

[NiCool]

 Is this the same problem as trees not droping named blocks? I can't craft more than rough bowls with carpentry because it requires birch block but when i cut a birch trunk or log into blocks i get generic blocks.

[Sami]

Is this the same problem as trees not droping named blocks? I can't craft more than rough bowls with carpentry because it requires birch block but when i cut a birch trunk or log into blocks i get generic blocks.

Trees should drop named blocks, birches too. Just checked and works on my end at least. 
Are you encountering this issue within somekind modding, or as in using the vanilla game mechanics?

[NiCool]

 Yeah, my bad. Was using a migrated character who had some generic blocks about. Just tested it again and trees do indeed drop named blocks.
.

.